From: kernel test robot <lkp@intel.com>
Date: Mon, 22 Mar 2021 18:21:39 +0000 (+0100)
Subject: of: overlay: fix for_each_child.cocci warnings
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c4d74f0f978ed5ceee62cd3f6708081042e582a1;p=linux.git

of: overlay: fix for_each_child.cocci warnings

Function "for_each_child_of_node" should have of_node_put() before goto.

Generated by: scripts/coccinelle/iterators/for_each_child.cocci

Fixes: 82c2d81361ec ("coccinelle: iterators: Add for_each_child.cocci script")
CC: Sumera Priyadarsini <sylphrenadin@gmail.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@inria.fr>
Reviewed-by: Frank Rowand <frank.rowand@sony.com>
Tested-by: Frank Rowand <frank.rowand@sony.com>
Link: https://lore.kernel.org/r/alpine.DEB.2.22.394.2103221918450.2918@hadrien
Signed-off-by: Rob Herring <robh@kernel.org>
---

diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index 1c867a5e4c7c2..c25679f7bd3fc 100644
--- a/drivers/of/overlay.c
+++ b/drivers/of/overlay.c
@@ -796,6 +796,7 @@ static int init_overlay_changeset(struct overlay_changeset *ovcs,
 		if (!fragment->target) {
 			of_node_put(fragment->overlay);
 			ret = -EINVAL;
+			of_node_put(node);
 			goto err_free_fragments;
 		}