From: Hangyu Hua <hbh25y@gmail.com>
Date: Fri, 15 Jul 2022 06:23:01 +0000 (+0800)
Subject: ipc: mqueue: fix possible memory leak in init_mqueue_fs()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c579d60f0d0cd87552f64fdebe68b5d941d20309;p=linux.git

ipc: mqueue: fix possible memory leak in init_mqueue_fs()

commit db7cfc380900 ("ipc: Free mq_sysctls if ipc namespace creation
failed")

Here's a similar memory leak to the one fixed by the patch above.
retire_mq_sysctls need to be called when init_mqueue_fs fails after
setup_mq_sysctls.

Fixes: dc55e35f9e81 ("ipc: Store mqueue sysctls in the ipc namespace")
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lkml.kernel.org/r/20220715062301.19311-1-hbh25y@gmail.com
Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
---

diff --git a/ipc/mqueue.c b/ipc/mqueue.c
index 12ad7860bb88f..83370fef88796 100644
--- a/ipc/mqueue.c
+++ b/ipc/mqueue.c
@@ -1746,6 +1746,7 @@ out_filesystem:
 	unregister_filesystem(&mqueue_fs_type);
 out_sysctl:
 	kmem_cache_destroy(mqueue_inode_cachep);
+	retire_mq_sysctls(&init_ipc_ns);
 	return error;
 }