From: yang.yang29@zte.com.cn <yang.yang29@zte.com.cn>
Date: Mon, 5 Dec 2022 11:36:40 +0000 (+0800)
Subject: ipmi/watchdog: use strscpy() to instead of strncpy()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c6f613e5f35b0e2154d5ca12f0e8e0be0c19be9a;p=linux.git

ipmi/watchdog: use strscpy() to instead of strncpy()

Xu Panda <xu.panda@zte.com.cn>

The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.

Signed-off-by: Xu Panda <xu.panda@zte.com.cn>
Signed-off-by: Yang Yang <yang.yang29@zte.com>
Message-Id: <202212051936400309332@zte.com.cn>
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---

diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 47365150e4310..0d4a8dcacfd4b 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -213,8 +213,7 @@ static int set_param_str(const char *val, const struct kernel_param *kp)
 	char       valcp[16];
 	char       *s;
 
-	strncpy(valcp, val, 15);
-	valcp[15] = '\0';
+	strscpy(valcp, val, 16);
 
 	s = strstrip(valcp);