From: Mika Westerberg Date: Wed, 8 Jan 2020 12:53:16 +0000 (+0300) Subject: thunderbolt: Fix xhci check in usb4_switch_setup() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c7a7ac84afeaf310a0ee477fc114e1e291a37c43;p=linux.git thunderbolt: Fix xhci check in usb4_switch_setup() The code tried to check whether xhci variable has ROUTER_CS_6_HCI bit set but since xhci type is bool and it already holds true or false based on that very bit, fix the check to use the variable directly. Reported-by: Dan Carpenter Fixes: b04079837b20 ("thunderbolt: Add initial support for USB4") Signed-off-by: Mika Westerberg Link: https://lore.kernel.org/r/20200108125317.36444-2-mika.westerberg@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/thunderbolt/usb4.c b/drivers/thunderbolt/usb4.c index dbe7ecce45052..b341fc60c4ba4 100644 --- a/drivers/thunderbolt/usb4.c +++ b/drivers/thunderbolt/usb4.c @@ -239,7 +239,7 @@ int usb4_switch_setup(struct tb_switch *sw) * and the parent does not have any USB3 dowstream * adapters (so we cannot do USB 3.x tunneling). */ - if (xhci & ROUTER_CS_6_HCI) + if (xhci) val |= ROUTER_CS_5_HCO; }