From: Jan Kara <jack@suse.cz>
Date: Fri, 20 Oct 2023 11:21:24 +0000 (+0200)
Subject: quota: Replace BUG_ON in dqput()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c8238508c85e262d46e19e2ff039d9238d436321;p=linux.git

quota: Replace BUG_ON in dqput()

The BUG_ON in dqput() will likely take the whole machine down when it
hits. Replace it with WARN_ON_ONCE() instead and stop hiding that behind
CONFIG_QUOTA_DEBUG.

Signed-off-by: Jan Kara <jack@suse.cz>
---

diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c
index 1f0c754416b64..d863d6b1ff97d 100644
--- a/fs/quota/dquot.c
+++ b/fs/quota/dquot.c
@@ -875,10 +875,7 @@ void dqput(struct dquot *dquot)
 	}
 
 	/* Need to release dquot? */
-#ifdef CONFIG_QUOTA_DEBUG
-	/* sanity check */
-	BUG_ON(!list_empty(&dquot->dq_free));
-#endif
+	WARN_ON_ONCE(!list_empty(&dquot->dq_free));
 	put_releasing_dquots(dquot);
 	atomic_dec(&dquot->dq_count);
 	spin_unlock(&dq_list_lock);