From: Steve French <smfrench@gmail.com>
Date: Fri, 27 Mar 2015 06:15:02 +0000 (-0500)
Subject: Fix warning on impossible comparison
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c85c35f8fc1d3f5ca60cd713f10af387de73cb94;p=linux.git

Fix warning on impossible comparison

workstation_RFC1001_name is part of the struct and can't be null,
remove impossible comparison (array vs. null)

Pointed out by Coverity (CID 140095)

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeff Layton <jlayton@samba.org>
---

diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index cdb1aaf295b12..480cf9c81d505 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -2917,8 +2917,7 @@ ip_rfc1001_connect(struct TCP_Server_Info *server)
 		 * calling name ends in null (byte 16) from old smb
 		 * convention.
 		 */
-		if (server->workstation_RFC1001_name &&
-		    server->workstation_RFC1001_name[0] != 0)
+		if (server->workstation_RFC1001_name[0] != 0)
 			rfc1002mangle(ses_init_buf->trailer.
 				      session_req.calling_name,
 				      server->workstation_RFC1001_name,