From: Yangtao Li Date: Mon, 27 Feb 2023 12:02:16 +0000 (+0800) Subject: quota: make dquot_set_dqinfo return errors from ->write_info X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c87d175d0ae715a1cdd9a315253f3fb410fb0421;p=linux.git quota: make dquot_set_dqinfo return errors from ->write_info dquot_set_dqinfo() ignores the return code from the ->write_info call, which means that quotacalls like Q_SETINFO never see the error. This doesn't seem right, so fix that. Signed-off-by: Yangtao Li Signed-off-by: Jan Kara Message-Id: <20230227120216.31306-2-frank.li@vivo.com> --- diff --git a/fs/quota/dquot.c b/fs/quota/dquot.c index 90cb70c82012c..78c9977549efa 100644 --- a/fs/quota/dquot.c +++ b/fs/quota/dquot.c @@ -2819,7 +2819,6 @@ EXPORT_SYMBOL(dquot_get_state); int dquot_set_dqinfo(struct super_block *sb, int type, struct qc_info *ii) { struct mem_dqinfo *mi; - int err = 0; if ((ii->i_fieldmask & QC_WARNS_MASK) || (ii->i_fieldmask & QC_RT_SPC_TIMER)) @@ -2846,8 +2845,7 @@ int dquot_set_dqinfo(struct super_block *sb, int type, struct qc_info *ii) spin_unlock(&dq_data_lock); mark_info_dirty(sb, type); /* Force write to disk */ - sb->dq_op->write_info(sb, type); - return err; + return sb->dq_op->write_info(sb, type); } EXPORT_SYMBOL(dquot_set_dqinfo);