From: Paolo Bonzini <pbonzini@redhat.com>
Date: Tue, 23 Jun 2020 19:54:25 +0000 (-0400)
Subject: ibex_uart: fix XOR-as-pow
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c8d7fd059d73a7d3035e379c319034c30ba3dbbf;p=qemu.git

ibex_uart: fix XOR-as-pow

The xor-as-pow warning in clang actually detected a genuine bug.
Fix it.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/hw/char/ibex_uart.c b/hw/char/ibex_uart.c
index 3e0dd9968e..45cd724998 100644
--- a/hw/char/ibex_uart.c
+++ b/hw/char/ibex_uart.c
@@ -331,7 +331,7 @@ static void ibex_uart_write(void *opaque, hwaddr addr,
         if (value & UART_CTRL_NCO) {
             uint64_t baud = ((value & UART_CTRL_NCO) >> 16);
             baud *= 1000;
-            baud /= 2 ^ 20;
+            baud >>= 20;
 
             s->char_tx_time = (NANOSECONDS_PER_SECOND / baud) * 10;
         }