From: Jernej Skrabec Date: Sat, 9 Sep 2023 06:36:12 +0000 (+0200) Subject: pinctrl: pinmux: Remove duplicate error message in pin_request() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c9336ebe87e77f92ed04a86c0131a0310d0e200d;p=linux.git pinctrl: pinmux: Remove duplicate error message in pin_request() Detailed error message is already printed at the end of the function, so drop redundant one a few lines earlier. Signed-off-by: Jernej Skrabec Link: https://lore.kernel.org/r/20230909063613.2867-2-jernej.skrabec@gmail.com Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 2a180a5d64a4a..301fe0157b028 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -173,10 +173,8 @@ static int pin_request(struct pinctrl_dev *pctldev, else status = 0; - if (status) { - dev_err(pctldev->dev, "request() failed for pin %d\n", pin); + if (status) module_put(pctldev->owner); - } out_free_pin: if (status) {