From: Uwe Kleine-König Date: Sat, 24 Aug 2019 15:37:06 +0000 (+0200) Subject: pwm: fsl-ftm: Don't update the state for the caller of pwm_apply_state() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=c9675829ba4b0e95c613f6d6d83d2b5cb9c5371c;p=linux.git pwm: fsl-ftm: Don't update the state for the caller of pwm_apply_state() The pwm-fsl-ftm driver is one of only three PWM drivers which updates the state for the caller of pwm_apply_state(). This might have surprising results if the caller reuses the values expecting them to still represent the same state. Signed-off-by: Uwe Kleine-König Signed-off-by: Thierry Reding --- diff --git a/drivers/pwm/pwm-fsl-ftm.c b/drivers/pwm/pwm-fsl-ftm.c index 9d31a217111d0..3c9738617cebc 100644 --- a/drivers/pwm/pwm-fsl-ftm.c +++ b/drivers/pwm/pwm-fsl-ftm.c @@ -292,10 +292,6 @@ static int fsl_pwm_apply_config(struct fsl_pwm_chip *fpc, regmap_update_bits(fpc->regmap, FTM_POL, BIT(pwm->hwpwm), reg_polarity); - newstate->period = fsl_pwm_ticks_to_ns(fpc, - fpc->period.mod_period + 1); - newstate->duty_cycle = fsl_pwm_ticks_to_ns(fpc, duty); - ftm_set_write_protection(fpc); return 0;