From: Dan Carpenter Date: Fri, 25 Jun 2021 13:01:04 +0000 (+0300) Subject: platform/x86: intel_skl_int3472: Uninitialized variable in skl_int3472_handle_gpio_re... X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=caf23895ce96e90d8667328144344263ff0e7f1f;p=linux.git platform/x86: intel_skl_int3472: Uninitialized variable in skl_int3472_handle_gpio_resources() This function returns negative error codes, zero (to indicate that everything has been completed successfully) and one (to indicate that more resources need to be handled still). This code prints an uninitialized error message when the function returns one which potentially leads to an Oops. Fixes: 5de691bffe57 ("platform/x86: Add intel_skl_int3472 driver") Signed-off-by: Dan Carpenter Reviewed-by: Daniel Scally Link: https://lore.kernel.org/r/YNXTkLNtiTDlFlZa@mwanda Signed-off-by: Hans de Goede --- diff --git a/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c b/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c index 17c6fe8307652..9fe0a2527e1cd 100644 --- a/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c +++ b/drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c @@ -286,10 +286,10 @@ static int skl_int3472_handle_gpio_resources(struct acpi_resource *ares, int3472->ngpios++; ACPI_FREE(obj); - if (ret) + if (ret < 0) return dev_err_probe(int3472->dev, ret, err_msg); - return 0; + return ret; } static int skl_int3472_parse_crs(struct int3472_discrete_device *int3472)