From: Eric Biggers Date: Tue, 10 May 2022 18:32:32 +0000 (-0700) Subject: ext4: reject the 'commit' option on ext2 filesystems X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=cb8435dc8ba33bcafa41cf2aa253794320a3b8df;p=linux.git ext4: reject the 'commit' option on ext2 filesystems The 'commit' option is only applicable for ext3 and ext4 filesystems, and has never been accepted by the ext2 filesystem driver, so the ext4 driver shouldn't allow it on ext2 filesystems. This fixes a failure in xfstest ext4/053. Fixes: 8dc0aa8cf0f7 ("ext4: check incompatible mount options while mounting ext2/3") Signed-off-by: Eric Biggers Reviewed-by: Ritesh Harjani Reviewed-by: Lukas Czerner Link: https://lore.kernel.org/r/20220510183232.172615-1-ebiggers@kernel.org --- diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 4b0ea8df1f5cc..3f59efd3aa3e2 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1915,6 +1915,7 @@ static const struct mount_opts { MOPT_EXT4_ONLY | MOPT_CLEAR}, {Opt_warn_on_error, EXT4_MOUNT_WARN_ON_ERROR, MOPT_SET}, {Opt_nowarn_on_error, EXT4_MOUNT_WARN_ON_ERROR, MOPT_CLEAR}, + {Opt_commit, 0, MOPT_NO_EXT2}, {Opt_nojournal_checksum, EXT4_MOUNT_JOURNAL_CHECKSUM, MOPT_EXT4_ONLY | MOPT_CLEAR}, {Opt_journal_checksum, EXT4_MOUNT_JOURNAL_CHECKSUM,