From: Heiner Kallweit Date: Sat, 27 Jan 2024 15:08:18 +0000 (+0100) Subject: mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ccf1445204a1dec2a4807fc7f7062e273bd7cb58;p=linux.git mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list Class-based I2C probing requires detect() and address_list to be set in the I2C client driver, see checks in i2c_detect(). It's misleading to declare I2C_CLASS_HWMON support if this precondition isn't met. Signed-off-by: Heiner Kallweit Reviewed-by: Ido Schimmel Link: https://lore.kernel.org/r/77b5ab8e-20f2-4310-bd89-57db99e2f53b@gmail.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c index 6b98c3287b497..f0ceb196a6cea 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c +++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c @@ -708,7 +708,6 @@ static const struct i2c_device_id mlxsw_m_i2c_id[] = { static struct i2c_driver mlxsw_m_i2c_driver = { .driver.name = "mlxsw_minimal", - .class = I2C_CLASS_HWMON, .id_table = mlxsw_m_i2c_id, };