From: Yang Yingliang <yangyingliang@huawei.com>
Date: Tue, 30 Mar 2021 12:55:39 +0000 (+0800)
Subject: net: mhi: remove pointless conditional before kfree_skb()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=cda1893e9f7c1d78e391dbb6ef1798cd32354113;p=linux.git

net: mhi: remove pointless conditional before kfree_skb()

It already has null pointer check in kfree_skb(),
remove pointless pointer check before kfree_skb().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/mhi/net.c b/drivers/net/mhi/net.c
index 5ec7a29f668d7..0d8293a47a56d 100644
--- a/drivers/net/mhi/net.c
+++ b/drivers/net/mhi/net.c
@@ -361,8 +361,7 @@ static void mhi_net_remove(struct mhi_device *mhi_dev)
 
 	mhi_unprepare_from_transfer(mhi_netdev->mdev);
 
-	if (mhi_netdev->skbagg_head)
-		kfree_skb(mhi_netdev->skbagg_head);
+	kfree_skb(mhi_netdev->skbagg_head);
 
 	free_netdev(mhi_netdev->ndev);
 }