From: Andy Shevchenko Date: Sat, 9 Jul 2022 00:07:09 +0000 (+0300) Subject: spi: remove duplicate parameters check in acpi_spi_add_resource() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=cdb0cc9379f1b4fa5ea3e0492bacf8008f3f4e5a;p=linux.git spi: remove duplicate parameters check in acpi_spi_add_resource() The acpi_spi_add_resource() is never called with ctrl == NULL and index == -1. The only caller already performs the check. Hence remove the duplication from the acpi_spi_add_resource(). Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20220709000709.35622-2-andriy.shevchenko@linux.intel.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 46c8f3ff89cb3..562d6441c7fd9 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -2453,9 +2453,6 @@ static int acpi_spi_add_resource(struct acpi_resource *ares, void *data) if (lookup->index != -1 && lookup->n++ != lookup->index) return 1; - if (lookup->index == -1 && !ctlr) - return -ENODEV; - status = acpi_get_handle(NULL, sb->resource_source.string_ptr, &parent_handle);