From: Konrad Dybcio Date: Fri, 11 Aug 2023 20:50:57 +0000 (+0200) Subject: crypto: qcom-rng: Make the core clock optional regardless of ACPI presence X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=cdb8b7e1692a81f26030050ec30aadd2e7538fef;p=linux.git crypto: qcom-rng: Make the core clock optional regardless of ACPI presence Some newer SoCs (like SM8450) do not require a clock vote for the PRNG to function. Make it entirely optional and rely on the bindings checker to ensure platforms that need it, consume one. Signed-off-by: Konrad Dybcio Reviewed-by: Bjorn Andersson Signed-off-by: Herbert Xu --- diff --git a/drivers/crypto/qcom-rng.c b/drivers/crypto/qcom-rng.c index 72dd1a4ebac44..825a729f205e5 100644 --- a/drivers/crypto/qcom-rng.c +++ b/drivers/crypto/qcom-rng.c @@ -173,13 +173,9 @@ static int qcom_rng_probe(struct platform_device *pdev) if (IS_ERR(rng->base)) return PTR_ERR(rng->base); - /* ACPI systems have clk already on, so skip clk_get */ - if (!has_acpi_companion(&pdev->dev)) { - rng->clk = devm_clk_get(&pdev->dev, "core"); - if (IS_ERR(rng->clk)) - return PTR_ERR(rng->clk); - } - + rng->clk = devm_clk_get_optional(&pdev->dev, "core"); + if (IS_ERR(rng->clk)) + return PTR_ERR(rng->clk); rng->skip_init = (unsigned long)device_get_match_data(&pdev->dev);