From: Antoine Tenart Date: Mon, 14 May 2018 13:10:59 +0000 (+0200) Subject: crypto: inside-secure - make the key and context size computation dynamic X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ce6795593ba572ace9195b8e573e15f86fb411dd;p=linux.git crypto: inside-secure - make the key and context size computation dynamic This patches makes the key and context size computation dynamic when using memzero_explicit() on these two arrays. This is safer, cleaner and will help future modifications of the driver when these two parameters sizes will changes (the context size will be bigger when using AEAD algorithms). Signed-off-by: Antoine Tenart Signed-off-by: Herbert Xu --- diff --git a/drivers/crypto/inside-secure/safexcel_cipher.c b/drivers/crypto/inside-secure/safexcel_cipher.c index 26f6e05726eaf..1f4787ea27254 100644 --- a/drivers/crypto/inside-secure/safexcel_cipher.c +++ b/drivers/crypto/inside-secure/safexcel_cipher.c @@ -554,13 +554,13 @@ static int safexcel_cipher_cra_exit(struct crypto_tfm *tfm) { struct safexcel_cipher_ctx *ctx = crypto_tfm_ctx(tfm); - memzero_explicit(ctx->key, 8 * sizeof(u32)); + memzero_explicit(ctx->key, sizeof(ctx->key)); /* context not allocated, skip invalidation */ if (!ctx->base.ctxr) return -ENOMEM; - memzero_explicit(ctx->base.ctxr->data, 8 * sizeof(u32)); + memzero_explicit(ctx->base.ctxr->data, sizeof(ctx->base.ctxr->data)); return 0; }