From: Haowen Bai <baihaowen@meizu.com>
Date: Thu, 21 Apr 2022 01:43:13 +0000 (+0800)
Subject: firmware: edd: Remove redundant condition
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=cebdc5349fba7ba9a76a756d35997d010cd1aac2;p=linux.git

firmware: edd: Remove redundant condition

The logic (!A || (A && B)) is equivalent to (!A || B). so we have
to make code clear.

Signed-off-by: Haowen Bai <baihaowen@meizu.com>
Link: https://lore.kernel.org/r/1650505393-19398-1-git-send-email-baihaowen@meizu.com
Reviewed-by: Griffin Kroah-Hartman <griffin@kroah.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c
index 69353dd0ea221..5cc238916551a 100644
--- a/drivers/firmware/edd.c
+++ b/drivers/firmware/edd.c
@@ -685,8 +685,7 @@ static void edd_populate_dir(struct edd_device * edev)
 	int i;
 
 	for (i = 0; (attr = edd_attrs[i]) && !error; i++) {
-		if (!attr->test ||
-		    (attr->test && attr->test(edev)))
+		if (!attr->test || attr->test(edev))
 			error = sysfs_create_file(&edev->kobj,&attr->attr);
 	}