From: Chris Wilson Date: Tue, 7 Apr 2020 22:26:25 +0000 (+0100) Subject: drm/i915/selftests: Drop vestigal timeslicing assert X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=cf4c826d96da8784a711c4bf84d656a93c1280bf;p=linux.git drm/i915/selftests: Drop vestigal timeslicing assert Since the semaphore interrupt may cause us to yield the timeslice immediately, we may cancel the timer before we notice the submission is complete. The assertion is no longer valid due to the race with the interrupt. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin Link: https://patchwork.freedesktop.org/patch/msgid/20200407222625.15542-1-chris@chris-wilson.co.uk --- diff --git a/drivers/gpu/drm/i915/gt/selftest_lrc.c b/drivers/gpu/drm/i915/gt/selftest_lrc.c index 43362b8a58559..57db3d0ffaf21 100644 --- a/drivers/gpu/drm/i915/gt/selftest_lrc.c +++ b/drivers/gpu/drm/i915/gt/selftest_lrc.c @@ -1073,7 +1073,6 @@ static int live_timeslice_rewind(void *arg) engine->name); goto err; } - GEM_BUG_ON(!timer_pending(&engine->execlists.timer)); /* ELSP[] = { { A:rq1, A:rq2 }, { B:rq1 } } */ if (i915_request_is_active(rq[A2])) { /* semaphore yielded! */