From: Krzysztof Kozlowski Date: Thu, 27 Aug 2020 20:08:22 +0000 (+0200) Subject: gpio: bcm-kona: Simplify with dev_err_probe() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=cff9d73f3d6a9f7ac41351c93b2969b7d3695821;p=linux.git gpio: bcm-kona: Simplify with dev_err_probe() Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Andy Shevchenko Acked-by: Florian Fainelli Signed-off-by: Bartosz Golaszewski --- diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index cf3687a7925ff..1e6b427f2c4a2 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c @@ -590,10 +590,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev) dev_err(dev, "Couldn't determine # GPIO banks\n"); return -ENOENT; } else if (ret < 0) { - if (ret != -EPROBE_DEFER) - dev_err(dev, "Couldn't determine GPIO banks: (%pe)\n", - ERR_PTR(ret)); - return ret; + return dev_err_probe(dev, ret, "Couldn't determine GPIO banks\n"); } kona_gpio->num_bank = ret;