From: Jia He <hejianet@gmail.com>
Date: Tue, 3 Aug 2021 10:59:37 +0000 (+0200)
Subject: lockd: change the proc_handler for nsm_use_hostnames
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d02a3a2cb25d384005a6e3446a445013342024b7;p=linux.git

lockd: change the proc_handler for nsm_use_hostnames

nsm_use_hostnames is a module parameter and it will be exported to sysctl
procfs. This is to let user sometimes change it from userspace. But the
minimal unit for sysctl procfs read/write it sizeof(int).
In big endian system, the converting from/to  bool to/from int will cause
error for proc items.

This patch use a new proc_handler proc_dobool to fix it.

Signed-off-by: Jia He <hejianet@gmail.com>
Reviewed-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>
[thuth: Fix typo in commit message]
Signed-off-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---

diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
index 2de048f80eb8c..0ab9756ed2359 100644
--- a/fs/lockd/svc.c
+++ b/fs/lockd/svc.c
@@ -584,7 +584,7 @@ static struct ctl_table nlm_sysctls[] = {
 		.data		= &nsm_use_hostnames,
 		.maxlen		= sizeof(int),
 		.mode		= 0644,
-		.proc_handler	= proc_dointvec,
+		.proc_handler	= proc_dobool,
 	},
 	{
 		.procname	= "nsm_local_state",