From: Ngo Tak Fong Date: Tue, 7 Dec 2021 21:22:23 +0000 (+0800) Subject: staging: rtl8712: Fix alignment checks with flipped condition X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d0df53d36cd51154463796bc6abdd11abdbc67c1;p=linux.git staging: rtl8712: Fix alignment checks with flipped condition Fixed two CHECKs of Alignment should match open parenthesis and flipped a condition to pull the code in one tab. Reviewed-by: Dan Carpenter Signed-off-by: Ngo Tak Fong Link: https://lore.kernel.org/r/20211207212223.GA70594@simon-desktop Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c b/drivers/staging/rtl8712/rtl8712_efuse.c index 4f3b54a7c3beb..c9400e40a1d63 100644 --- a/drivers/staging/rtl8712/rtl8712_efuse.c +++ b/drivers/staging/rtl8712/rtl8712_efuse.c @@ -298,25 +298,23 @@ static u8 fix_header(struct _adapter *adapter, u8 header, u16 header_addr) continue; } for (i = 0; i < PGPKG_MAX_WORDS; i++) { - if (BIT(i) & word_en) { - if (BIT(i) & pkt.word_en) { - if (efuse_one_byte_read( - adapter, addr, + if (!(BIT(i) & word_en)) + continue; + if (BIT(i) & pkt.word_en) { + if (efuse_one_byte_read(adapter, + addr, &value)) - pkt.data[i * 2] = value; - else - return false; - if (efuse_one_byte_read( - adapter, + pkt.data[i * 2] = value; + else + return false; + if (efuse_one_byte_read(adapter, addr + 1, &value)) - pkt.data[i * 2 + 1] = - value; - else - return false; - } - addr += 2; + pkt.data[i * 2 + 1] = value; + else + return false; } + addr += 2; } } if (addr != header_addr)