From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Mon, 4 Nov 2019 09:15:36 +0000 (+0300)
Subject: bpf, offload: Unlock on error in bpf_offload_dev_create()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d0fbb51dfaa612f960519b798387be436e8f83c5;p=linux.git

bpf, offload: Unlock on error in bpf_offload_dev_create()

We need to drop the bpf_devs_lock on error before returning.

Fixes: 9fd7c5559165 ("bpf: offload: aggregate offloads per-device")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Link: https://lore.kernel.org/bpf/20191104091536.GB31509@mwanda
---

diff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c
index ba635209ae9a8..5b9da0954a27f 100644
--- a/kernel/bpf/offload.c
+++ b/kernel/bpf/offload.c
@@ -678,8 +678,10 @@ bpf_offload_dev_create(const struct bpf_prog_offload_ops *ops, void *priv)
 	down_write(&bpf_devs_lock);
 	if (!offdevs_inited) {
 		err = rhashtable_init(&offdevs, &offdevs_params);
-		if (err)
+		if (err) {
+			up_write(&bpf_devs_lock);
 			return ERR_PTR(err);
+		}
 		offdevs_inited = true;
 	}
 	up_write(&bpf_devs_lock);