From: Austin Kim Date: Tue, 9 Nov 2021 00:37:42 +0000 (+0000) Subject: ALSA: synth: missing check for possible NULL after the call to kstrdup X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d159037abbe3412285c271bdfb9cdf19e62678ff;p=linux.git ALSA: synth: missing check for possible NULL after the call to kstrdup If kcalloc() return NULL due to memory starvation, it is possible for kstrdup() to return NULL in similar case. So add null check after the call to kstrdup() is made. [ minor coding-style fix by tiwai ] Signed-off-by: Austin Kim Cc: Link: https://lore.kernel.org/r/20211109003742.GA5423@raspberrypi Signed-off-by: Takashi Iwai --- diff --git a/sound/synth/emux/emux.c b/sound/synth/emux/emux.c index 49d1976a132c0..5ed8e36d2e043 100644 --- a/sound/synth/emux/emux.c +++ b/sound/synth/emux/emux.c @@ -88,7 +88,7 @@ int snd_emux_register(struct snd_emux *emu, struct snd_card *card, int index, ch emu->name = kstrdup(name, GFP_KERNEL); emu->voices = kcalloc(emu->max_voices, sizeof(struct snd_emux_voice), GFP_KERNEL); - if (emu->voices == NULL) + if (emu->name == NULL || emu->voices == NULL) return -ENOMEM; /* create soundfont list */