From: Shannon Nelson Date: Tue, 12 Oct 2021 23:15:20 +0000 (-0700) Subject: ionic: no devlink_unregister if not registered X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d1f24712a86abd04d82cf4b00fb4ab8ff2d23c8a;p=linux.git ionic: no devlink_unregister if not registered Don't try to unregister the devlink if it hasn't been registered yet. This bit of error cleanup code got missed in the recent devlink registration changes. Fixes: 7911c8bd546f ("ionic: Move devlink registration to be last devlink command") Signed-off-by: Shannon Nelson Reviewed-by: Leon Romanovsky Link: https://lore.kernel.org/r/20211012231520.72582-1-snelson@pensando.io Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c index 2267da95640be..4297ed9024c01 100644 --- a/drivers/net/ethernet/pensando/ionic/ionic_devlink.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_devlink.c @@ -87,7 +87,6 @@ int ionic_devlink_register(struct ionic *ionic) err = devlink_port_register(dl, &ionic->dl_port, 0); if (err) { dev_err(ionic->dev, "devlink_port_register failed: %d\n", err); - devlink_unregister(dl); return err; }