From: Markus Elfring Date: Sat, 3 Jan 2015 14:10:52 +0000 (+0100) Subject: sound: oss: Deletion of unnecessary checks before the function call "vfree" X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d1f45e6037f1195d10cf363e94a08ee2f10f9b41;p=linux.git sound: oss: Deletion of unnecessary checks before the function call "vfree" The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai --- diff --git a/sound/oss/pss.c b/sound/oss/pss.c index ca0d6e9f49f5b..81314f9e2ccb9 100644 --- a/sound/oss/pss.c +++ b/sound/oss/pss.c @@ -1228,7 +1228,7 @@ static void __exit cleanup_pss(void) { if(!pss_no_sound) { - if(fw_load && pss_synth) + if (fw_load) vfree(pss_synth); if(pssmss) unload_pss_mss(&cfg2); diff --git a/sound/oss/trix.c b/sound/oss/trix.c index 944e0c0154853..3c494dc93b936 100644 --- a/sound/oss/trix.c +++ b/sound/oss/trix.c @@ -487,7 +487,7 @@ static int __init init_trix(void) static void __exit cleanup_trix(void) { - if (fw_load && trix_boot) + if (fw_load) vfree(trix_boot); if (sb) unload_trix_sb(&cfg2);