From: Al Viro <viro@zeniv.linux.org.uk>
Date: Sat, 9 Jun 2018 13:43:13 +0000 (-0400)
Subject: cxl_getfile(): fix double-iput() on alloc_file() failures
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d202797f480c0e5918e7642d6716cdc62b3ab5c9;p=linux.git

cxl_getfile(): fix double-iput() on alloc_file() failures

Doing iput() after path_put() is wrong.

Cc: stable@vger.kernel.org
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/drivers/misc/cxl/api.c b/drivers/misc/cxl/api.c
index 753b1a698fc4e..6b16946f9b05d 100644
--- a/drivers/misc/cxl/api.c
+++ b/drivers/misc/cxl/api.c
@@ -103,15 +103,15 @@ static struct file *cxl_getfile(const char *name,
 	d_instantiate(path.dentry, inode);
 
 	file = alloc_file(&path, OPEN_FMODE(flags), fops);
-	if (IS_ERR(file))
-		goto err_dput;
+	if (IS_ERR(file)) {
+		path_put(&path);
+		goto err_fs;
+	}
 	file->f_flags = flags & (O_ACCMODE | O_NONBLOCK);
 	file->private_data = priv;
 
 	return file;
 
-err_dput:
-	path_put(&path);
 err_inode:
 	iput(inode);
 err_fs: