From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Date: Sat, 5 Jun 2021 16:53:47 +0000 (+0200) Subject: misc/pvpanic: Remove some dead-code X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d208cbb0024ec0a5878bfd6c757c7f01872201ea;p=linux.git misc/pvpanic: Remove some dead-code 'pvpanic_remove()' is referenced only by a 'devm_add_action_or_reset()' call in 'devm_pvpanic_probe()'. So, we know that its parameter is non-NULL. Axe the unneeded check to save a few lines of code. Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/8e425618f4042a8ab8366be4d34026972e77bd40.1622911768.git.christophe.jaillet@wanadoo.fr Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- diff --git a/drivers/misc/pvpanic/pvpanic.c b/drivers/misc/pvpanic/pvpanic.c index 29f63a31edbc1..b6bd6abc29525 100644 --- a/drivers/misc/pvpanic/pvpanic.c +++ b/drivers/misc/pvpanic/pvpanic.c @@ -65,9 +65,6 @@ static void pvpanic_remove(void *param) struct pvpanic_instance *pi_cur, *pi_next; struct pvpanic_instance *pi = param; - if (!pi) - return; - spin_lock(&pvpanic_lock); list_for_each_entry_safe(pi_cur, pi_next, &pvpanic_list, list) { if (pi_cur == pi) {