From: Finn Thain Date: Sat, 15 Feb 2020 21:03:32 +0000 (+1100) Subject: net/sonic: Remove redundant netif_start_queue() call X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d35bf9bc7d72a5e3055c808e5d5530a81a0c9a38;p=linux.git net/sonic: Remove redundant netif_start_queue() call The transmit queue must be running already otherwise sonic_send_packet() would not have been called. If the queue was stopped by the interrupt handler, the interrupt handler will restart it again. Tested-by: Stan Johnson Signed-off-by: Finn Thain Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/natsemi/sonic.c b/drivers/net/ethernet/natsemi/sonic.c index 9ecdd67e1410a..1d6de6706875e 100644 --- a/drivers/net/ethernet/natsemi/sonic.c +++ b/drivers/net/ethernet/natsemi/sonic.c @@ -327,7 +327,7 @@ static int sonic_send_packet(struct sk_buff *skb, struct net_device *dev) netif_dbg(lp, tx_queued, dev, "%s: stopping queue\n", __func__); netif_stop_queue(dev); /* after this packet, wait for ISR to free up some TDAs */ - } else netif_start_queue(dev); + } netif_dbg(lp, tx_queued, dev, "%s: issuing Tx command\n", __func__);