From: Geert Uytterhoeven Date: Wed, 14 Jul 2021 15:15:59 +0000 (+0200) Subject: sysfs: Use local reference in compat_only_sysfs_link_entry_to_kobj() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d3ce197903279c5497d4fa9cc97b519400dc4a44;p=linux.git sysfs: Use local reference in compat_only_sysfs_link_entry_to_kobj() As we have just obtained target_kobj->sd into a local variable, and incremented the object's reference count, it is better to use the local variable instead of the original reference. Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20210714151559.2532572-1-geert@linux-m68k.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c index 64e6a6698935e..f29d620045272 100644 --- a/fs/sysfs/group.c +++ b/fs/sysfs/group.c @@ -446,7 +446,7 @@ int compat_only_sysfs_link_entry_to_kobj(struct kobject *kobj, if (!target) return -ENOENT; - entry = kernfs_find_and_get(target_kobj->sd, target_name); + entry = kernfs_find_and_get(target, target_name); if (!entry) { kernfs_put(target); return -ENOENT;