From: Nicholas Mc Guire Date: Wed, 4 Jul 2018 08:03:27 +0000 (+0200) Subject: powerpc/icp-hv: Fix missing of_node_put() in success path X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d3e669f31ec35856f5e85df9224ede5bdbf1bc7b;p=linux.git powerpc/icp-hv: Fix missing of_node_put() in success path Both of_find_compatible_node() and of_find_node_by_type() will return a refcounted node on success - thus for the success path the node must be explicitly released with a of_node_put(). Fixes: 0b05ac6e2480 ("powerpc/xics: Rewrite XICS driver") Signed-off-by: Nicholas Mc Guire Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/1530691407-3991-1-git-send-email-hofrat@osadl.org --- diff --git a/arch/powerpc/sysdev/xics/icp-hv.c b/arch/powerpc/sysdev/xics/icp-hv.c index ad8117148ea3b..21b9d1bf39ff6 100644 --- a/arch/powerpc/sysdev/xics/icp-hv.c +++ b/arch/powerpc/sysdev/xics/icp-hv.c @@ -174,6 +174,7 @@ int icp_hv_init(void) icp_ops = &icp_hv_ops; + of_node_put(np); return 0; }