From: Emilio G. Cota <cota@braap.org>
Date: Sun, 9 Jul 2017 07:49:54 +0000 (-0400)
Subject: translate-all: remove redundant !tcg_enabled check in dump_exec_info
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d40d3da00c10f0169a26985ecb65033bff536f2c;p=qemu.git

translate-all: remove redundant !tcg_enabled check in dump_exec_info

This check is redundant because it is already performed by the only
caller of dump_exec_info -- the caller was updated by b7da97eef
("monitor: Check whether TCG is enabled before running the "info jit"
code").

Checking twice wouldn't necessarily be too bad, but here the check also
returns with tb_lock held. So we can either do the check before tb_lock is
acquired, or just get rid of it. Given that it is redundant, I am going
for the latter option.

Signed-off-by: Emilio G. Cota <cota@braap.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 0caf80db75..4e1831cbb9 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -1851,11 +1851,6 @@ void dump_exec_info(FILE *f, fprintf_function cpu_fprintf)
 
     tb_lock();
 
-    if (!tcg_enabled()) {
-        cpu_fprintf(f, "TCG not enabled\n");
-        return;
-    }
-
     target_code_size = 0;
     max_target_code_size = 0;
     cross_page = 0;