From: Gustavo Sousa Date: Fri, 15 Sep 2023 22:02:33 +0000 (-0300) Subject: drm/xe: Simplify final return from xe_irq_install() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d435a039646eee712f4d5da2405181015c30bb1a;p=linux.git drm/xe: Simplify final return from xe_irq_install() At the end of the function, we will always return err no matter it's value. Simplify this by just returning the result of drmm_add_action_or_reset(). Reviewed-by: Matt Roper Link: https://lore.kernel.org/r/20230915220233.59736-1-gustavo.sousa@intel.com Signed-off-by: Gustavo Sousa Signed-off-by: Rodrigo Vivi --- diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c index ff71a3aa08ce4..dec3d518b3fc4 100644 --- a/drivers/gpu/drm/xe/xe_irq.c +++ b/drivers/gpu/drm/xe/xe_irq.c @@ -592,11 +592,7 @@ int xe_irq_install(struct xe_device *xe) xe_irq_postinstall(xe); - err = drmm_add_action_or_reset(&xe->drm, irq_uninstall, xe); - if (err) - return err; - - return err; + return drmm_add_action_or_reset(&xe->drm, irq_uninstall, xe); } void xe_irq_shutdown(struct xe_device *xe)