From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 6 Nov 2020 20:39:50 +0000 (-0500)
Subject: net/sunrpc: return 0 on attempt to write to "transports"
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d435c05ab0197ee302290e1cee3f2d9c9024a64f;p=linux.git

net/sunrpc: return 0 on attempt to write to "transports"

You can't write to this file because the permissions are 0444.  But
it sort of looked like you could do a write and it would result in
a read.  Then it looked like proc_sys_call_handler() just ignored
it.  Which is confusing.  It's more clear if the "write" just
returns zero.

Also, the "lenp" pointer is never NULL so that check can be removed.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---

diff --git a/net/sunrpc/sysctl.c b/net/sunrpc/sysctl.c
index a18b36b5422d4..5c9f5bca4d99d 100644
--- a/net/sunrpc/sysctl.c
+++ b/net/sunrpc/sysctl.c
@@ -65,7 +65,7 @@ static int proc_do_xprt(struct ctl_table *table, int write,
 	char tmpbuf[256];
 	size_t len;
 
-	if ((*ppos && !write) || !*lenp) {
+	if (write || *ppos) {
 		*lenp = 0;
 		return 0;
 	}