From: Minghao Chi <chi.minghao@zte.com.cn>
Date: Fri, 19 Aug 2022 08:14:20 +0000 (+0000)
Subject: isofs: delete unnecessary checks before brelse()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d4d361ad00bac10701a8c14d8e1a2967bd2e2813;p=linux.git

isofs: delete unnecessary checks before brelse()

The brelse() function tests whether its argument is NULL
and then returns immediately.
Thus remove the tests which are not needed around the shown calls.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
Signed-off-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220819081420.96209-1-chi.minghao@zte.com.cn
---

diff --git a/fs/isofs/inode.c b/fs/isofs/inode.c
index 88bf203034660..df9d70588b600 100644
--- a/fs/isofs/inode.c
+++ b/fs/isofs/inode.c
@@ -1277,13 +1277,11 @@ static int isofs_read_level3_size(struct inode *inode)
 	} while (more_entries);
 out:
 	kfree(tmpde);
-	if (bh)
-		brelse(bh);
+	brelse(bh);
 	return 0;
 
 out_nomem:
-	if (bh)
-		brelse(bh);
+	brelse(bh);
 	return -ENOMEM;
 
 out_noread:
@@ -1486,8 +1484,7 @@ static int isofs_read_inode(struct inode *inode, int relocated)
 	ret = 0;
 out:
 	kfree(tmpde);
-	if (bh)
-		brelse(bh);
+	brelse(bh);
 	return ret;
 
 out_badread: