From: Jiri Slaby Date: Mon, 24 Jan 2022 07:14:23 +0000 (+0100) Subject: tty: tty_port_open, document shutdown vs failed activate X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d56738a38a65ab785557a1ccf8257a486d1b93b6;p=linux.git tty: tty_port_open, document shutdown vs failed activate Add a note that ->shutdown is not called when ->activate fails. Just so we are clear. Signed-off-by: Jiri Slaby Link: https://lore.kernel.org/r/20220124071430.14907-5-jslaby@suse.cz Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/tty_port.c b/drivers/tty/tty_port.c index 7644834640f11..4282895ede9e1 100644 --- a/drivers/tty/tty_port.c +++ b/drivers/tty/tty_port.c @@ -736,6 +736,9 @@ EXPORT_SYMBOL_GPL(tty_port_install); * the device to be ready using tty_port_block_til_ready() (e.g. raises * DTR/CTS and waits for carrier). * + * Note that @port->ops->shutdown is not called when @port->ops->activate + * returns an error (on the contrary, @tty->ops->close is). + * * Locking: Caller holds tty lock. * * Note: may drop and reacquire tty lock (in tty_port_block_til_ready()) so