From: Chen Qun <kuhn.chenqun@huawei.com>
Date: Wed, 25 Mar 2020 02:59:17 +0000 (+0800)
Subject: scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d58f8860ddba8a316bdcdc1010ca4d2ed0b41941;p=qemu.git

scsi/esp-pci: add g_assert() for fix clang analyzer warning in esp_pci_io_write()

Clang static code analyzer show warning:
  hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read
        size = 4;
        ^      ~

Reported-by: Euler Robot <euler.robot@huawei.com>
Signed-off-by: Chen Qun <kuhn.chenqun@huawei.com>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20200325025919.21316-2-kuhn.chenqun@huawei.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---

diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c
index d5a1f9e017..497a8d5901 100644
--- a/hw/scsi/esp-pci.c
+++ b/hw/scsi/esp-pci.c
@@ -197,6 +197,7 @@ static void esp_pci_io_write(void *opaque, hwaddr addr,
         addr &= ~3;
         size = 4;
     }
+    g_assert(size >= 4);
 
     if (addr < 0x40) {
         /* SCSI core reg */