From: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Fri, 22 Apr 2022 10:51:47 +0000 (+0400)
Subject: io: replace pipe() with g_unix_open_pipe(CLOEXEC)
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d640b59eb3c7925568c5b101f439b0c0e65ea313;p=qemu.git

io: replace pipe() with g_unix_open_pipe(CLOEXEC)

Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/io/channel-command.c b/io/channel-command.c
index 338da73ade..539685ea83 100644
--- a/io/channel-command.c
+++ b/io/channel-command.c
@@ -76,8 +76,8 @@ qio_channel_command_new_spawn(const char *const argv[],
         }
     }
 
-    if ((!stdinnull && pipe(stdinfd) < 0) ||
-        (!stdoutnull && pipe(stdoutfd) < 0)) {
+    if ((!stdinnull && !g_unix_open_pipe(stdinfd, FD_CLOEXEC, NULL)) ||
+        (!stdoutnull && !g_unix_open_pipe(stdoutfd, FD_CLOEXEC, NULL))) {
         error_setg_errno(errp, errno,
                          "Unable to open pipe");
         goto error;