From: Takashi Iwai Date: Thu, 26 Jul 2018 12:58:03 +0000 (+0200) Subject: ALSA: trident: Suppress gcc string warning X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d6b340d7cb33c816ef4abe8143764ec5ab14a5cc;p=linux.git ALSA: trident: Suppress gcc string warning The meddlesome gcc warns about the possible shortname string in trident driver code: sound/pci/trident/trident.c: In function ‘snd_trident_probe’: sound/pci/trident/trident.c:126:2: warning: ‘strcat’ accessing 17 or more bytes at offsets 36 and 20 may overlap 1 byte at offset 36 [-Wrestrict] strcat(card->shortname, card->driver); It happens since gcc calculates the possible string size from card->driver, but this can't be true since we did set the string just before that, and they are much shorter. For shutting it up, use the exactly same string set to card->driver for strcat() to card->shortname, too. Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/trident/trident.c b/sound/pci/trident/trident.c index cedf13b64803a..2f18b1cdc2cd4 100644 --- a/sound/pci/trident/trident.c +++ b/sound/pci/trident/trident.c @@ -123,7 +123,7 @@ static int snd_trident_probe(struct pci_dev *pci, } else { strcpy(card->shortname, "Trident "); } - strcat(card->shortname, card->driver); + strcat(card->shortname, str); sprintf(card->longname, "%s PCI Audio at 0x%lx, irq %d", card->shortname, trident->port, trident->irq);