From: Gustavo A. R. Silva Date: Wed, 4 Jul 2018 16:37:20 +0000 (-0500) Subject: crypto: chtls - use 64-bit arithmetic instead of 32-bit X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d6be72ee2c77469d4fb391ccccc2ebc1b167a242;p=linux.git crypto: chtls - use 64-bit arithmetic instead of 32-bit Cast *val* to u64 in order to give the compiler complete information about the proper arithmetic to use. Notice that such variable is used in a context that expects an expression of type u64 (64 bits, unsigned) and the following expression is currently being evaluated using 32-bit arithmetic: val << bit_pos Addresses-Coverity-ID: 1467425 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Herbert Xu --- diff --git a/drivers/crypto/chelsio/chtls/chtls_hw.c b/drivers/crypto/chelsio/chtls/chtls_hw.c index 55d50140f9e5a..4909607558644 100644 --- a/drivers/crypto/chelsio/chtls/chtls_hw.c +++ b/drivers/crypto/chelsio/chtls/chtls_hw.c @@ -97,7 +97,7 @@ static int chtls_set_tcb_field(struct sock *sk, u16 word, u64 mask, u64 val) int chtls_set_tcb_tflag(struct sock *sk, unsigned int bit_pos, int val) { return chtls_set_tcb_field(sk, 1, 1ULL << bit_pos, - val << bit_pos); + (u64)val << bit_pos); } static int chtls_set_tcb_keyid(struct sock *sk, int keyid)