From: Azeem Shaikh Date: Tue, 23 May 2023 02:12:28 +0000 (+0000) Subject: leds: blinkm: Replace all non-returning strlcpy with strscpy X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d6e3896b7c22278c6f4a9b166211fdddf1c86c3a;p=linux.git leds: blinkm: Replace all non-returning strlcpy with strscpy strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Signed-off-by: Azeem Shaikh Reviewed-by: Kees Cook Link: https://lore.kernel.org/r/20230523021228.2406112-1-azeemshaikh38@gmail.com Signed-off-by: Lee Jones --- diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c index ae9fbd32c53da..2782da1a19307 100644 --- a/drivers/leds/leds-blinkm.c +++ b/drivers/leds/leds-blinkm.c @@ -561,7 +561,7 @@ static int blinkm_detect(struct i2c_client *client, struct i2c_board_info *info) return -ENODEV; } - strlcpy(info->type, "blinkm", I2C_NAME_SIZE); + strscpy(info->type, "blinkm", I2C_NAME_SIZE); return 0; }