From: Junlin Yang <yangjunlin@yulong.com>
Date: Thu, 11 Mar 2021 01:32:35 +0000 (+0800)
Subject: firmware: qcom_scm: remove a duplicative condition
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d775dab9a4a8f1279b65a80a445753a569338319;p=linux.git

firmware: qcom_scm: remove a duplicative condition

Fixes coccicheck warnings:
./drivers/firmware/qcom_scm.c:324:20-22:
WARNING !A || A && B is equivalent to !A || B

Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
Link: https://lore.kernel.org/r/20210311013235.1458-1-angkery@163.com
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---

diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
index 33db4a65c2b21..76bfa7ac28186 100644
--- a/drivers/firmware/qcom_scm.c
+++ b/drivers/firmware/qcom_scm.c
@@ -331,7 +331,7 @@ int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus)
 		.owner = ARM_SMCCC_OWNER_SIP,
 	};
 
-	if (!cpus || (cpus && cpumask_empty(cpus)))
+	if (!cpus || cpumask_empty(cpus))
 		return -EINVAL;
 
 	for_each_cpu(cpu, cpus) {