From: Dan Carpenter Date: Wed, 25 Sep 2019 11:01:00 +0000 (+0300) Subject: of: mdio: Fix a signedness bug in of_phy_get_and_connect() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d7eb651212fdbafa82d485d8e76095ac3b14c193;p=linux.git of: mdio: Fix a signedness bug in of_phy_get_and_connect() The "iface" variable is an enum and in this context GCC treats it as an unsigned int so the error handling is never triggered. Fixes: b78624125304 ("of_mdio: Abstract a general interface for phy connect") Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index 000b95787df15..bd6129db64178 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -362,7 +362,7 @@ struct phy_device *of_phy_get_and_connect(struct net_device *dev, int ret; iface = of_get_phy_mode(np); - if (iface < 0) + if ((int)iface < 0) return NULL; if (of_phy_is_fixed_link(np)) { ret = of_phy_register_fixed_link(np);