From: Uwe Kleine-König Date: Sun, 26 Mar 2023 14:31:10 +0000 (+0200) Subject: media: venus: Warn only once about problems in .remove() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d80250819e59c76ee447fd58cbffb6f750a21918;p=linux.git media: venus: Warn only once about problems in .remove() The only effect of returning an error code in a remove callback is that the driver core emits a warning. The device is unbound anyhow. As the remove callback already emits a (quite verbose) warning when ret is non-zero, return zero to suppress the additional warning. Signed-off-by: Uwe Kleine-König Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c index 990a1519f968d..403ffb92af609 100644 --- a/drivers/media/platform/qcom/venus/core.c +++ b/drivers/media/platform/qcom/venus/core.c @@ -448,7 +448,7 @@ static int venus_remove(struct platform_device *pdev) mutex_destroy(&core->lock); venus_dbgfs_deinit(core); - return ret; + return 0; } static void venus_core_shutdown(struct platform_device *pdev)