From: Colin Ian King Date: Fri, 17 Sep 2021 11:57:47 +0000 (+0100) Subject: octeontx2-af: Fix uninitialized variable val X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d853f1d3c900cc16758b12853375c1ab888fae65;p=linux.git octeontx2-af: Fix uninitialized variable val In the case where the condition !is_rvu_otx2(rvu) is false variable val is not initialized and can contain a garbage value. Fix this by initializing val to zero and bit-wise or'ing in BIT_ULL(51) to val for the true condition case of !is_rvu_otx2(rvu). Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 4b5a3ab17c6c ("octeontx2-af: Hardware configuration for inline IPsec") Signed-off-by: Colin Ian King Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c index ea3e03fa55d45..29b15b544bdc7 100644 --- a/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c +++ b/drivers/net/ethernet/marvell/octeontx2/af/rvu_nix.c @@ -4596,9 +4596,10 @@ static void nix_inline_ipsec_cfg(struct rvu *rvu, struct nix_inline_ipsec_cfg *r cpt_idx = (blkaddr == BLKADDR_NIX0) ? 0 : 1; if (req->enable) { + val = 0; /* Enable context prefetching */ if (!is_rvu_otx2(rvu)) - val = BIT_ULL(51); + val |= BIT_ULL(51); /* Set OPCODE and EGRP */ val |= FIELD_PREP(IPSEC_GEN_CFG_EGRP, req->gen_cfg.egrp);