From: Martin Kaiser Date: Sun, 3 Apr 2022 16:54:33 +0000 (+0200) Subject: staging: r8188eu: don't copy ra and ta before we fail X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d9290327e6f52851c82db5997deb76405df976a6;p=linux.git staging: r8188eu: don't copy ra and ta before we fail In validate_recv_data_frame, we return an error if both to_ds and from_ds are set in the incoming data frame. There's no need to populate patrib->ra and ta before we return. The caller will free the received frame, including pattrib. Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20220403165438.357728-7-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c index 47d4fd01824f2..c200e1251545a 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -974,11 +974,6 @@ static int validate_recv_data_frame(struct adapter *adapter, memcpy(pattrib->ta, psa, ETH_ALEN); ret = sta2ap_data_frame(adapter, precv_frame, &psta); break; - case 3: - memcpy(pattrib->ra, GetAddr1Ptr(ptr), ETH_ALEN); - memcpy(pattrib->ta, GetAddr2Ptr(ptr), ETH_ALEN); - ret = _FAIL; - break; default: ret = _FAIL; break;