From: Yu Kuai <yukuai3@huawei.com> Date: Fri, 9 Oct 2020 12:38:04 +0000 (+0200) Subject: media: mtk-vcodec: add missing put_device() call in mtk_vcodec_release_enc_pm() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=d940d2f46bfec6e206609cf44c6bd612a81d117e;p=linux.git media: mtk-vcodec: add missing put_device() call in mtk_vcodec_release_enc_pm() mtk_vcodec_release_enc_pm() will be called in two places: a. mtk_vcodec_init_enc_pm() succeed while mtk_vcodec_probe() return error. b. mtk_vcodec_enc_remove(). In both cases put_device() call is needed, since of_find_device_by_node() was called in mtk_vcodec_init_enc_pm() previously. Thus add put_devices() call in mtk_vcodec_release_enc_pm() Signed-off-by: Yu Kuai <yukuai3@huawei.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org> --- diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c index 1a047c25679fa..3b7c54d6aa8f8 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_pm.c @@ -108,6 +108,8 @@ put_larbvenc: void mtk_vcodec_release_enc_pm(struct mtk_vcodec_dev *mtkdev) { + put_device(mtkdev->pm.larbvenclt); + put_device(mtkdev->pm.larbvenc); }