From: Tom Rix Date: Thu, 21 Apr 2022 16:42:54 +0000 (-0400) Subject: ACPI: BGRT: use static for BGRT_SHOW kobj_attribute defines X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=db2d1693fae37e01e7fcfd627b407c18737e8373;p=linux.git ACPI: BGRT: use static for BGRT_SHOW kobj_attribute defines Smatch reports this repesentative issue: bgrt.c:26:1: warning: symbol 'bgrt_attr_version' was not declared. Should it be static? Similar for *status,type,xoffset,yoffset These variables are defined with the BGRT_SHOW macro. For the definition of bgrt_attr_##_name, the storage-class specifier should be static. Signed-off-by: Tom Rix Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/acpi/bgrt.c b/drivers/acpi/bgrt.c index 02d208732f9a3..e4fb9e225ddfc 100644 --- a/drivers/acpi/bgrt.c +++ b/drivers/acpi/bgrt.c @@ -21,7 +21,7 @@ static struct kobject *bgrt_kobj; { \ return sysfs_emit(buf, "%d\n", bgrt_tab._member); \ } \ - struct kobj_attribute bgrt_attr_##_name = __ATTR_RO(_name) + static struct kobj_attribute bgrt_attr_##_name = __ATTR_RO(_name) BGRT_SHOW(version, version); BGRT_SHOW(status, status);