From: Peilin Ye <peilin.ye@bytedance.com>
Date: Wed, 21 Sep 2022 00:59:15 +0000 (-0700)
Subject: udp: Use WARN_ON_ONCE() in udp_read_skb()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=db39dfdc1c3bd9da273902da12f01973792ff911;p=linux.git

udp: Use WARN_ON_ONCE() in udp_read_skb()

Prevent udp_read_skb() from flooding the syslog.

Suggested-by: Jakub Sitnicki <jakub@cloudflare.com>
Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
Link: https://lore.kernel.org/r/20220921005915.2697-1-yepeilin.cs@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index cd72158e953a5..560d9eadeaa58 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1821,7 +1821,7 @@ int udp_read_skb(struct sock *sk, skb_read_actor_t recv_actor)
 			continue;
 		}
 
-		WARN_ON(!skb_set_owner_sk_safe(skb, sk));
+		WARN_ON_ONCE(!skb_set_owner_sk_safe(skb, sk));
 		used = recv_actor(sk, skb);
 		if (used <= 0) {
 			if (!copied)