From: Kemeng Shi Date: Tue, 18 Oct 2022 11:12:38 +0000 (+0800) Subject: block: Remove redundant parent blkcg_gp check in check_scale_change X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=db5896e9cf93f119c0b181c5e6b473d8bf0302e5;p=linux.git block: Remove redundant parent blkcg_gp check in check_scale_change Function blkcg_iolatency_throttle will make sure blkg->parent is not NULL before calls check_scale_change. And function check_scale_change is only called in blkcg_iolatency_throttle. Signed-off-by: Kemeng Shi Reviewed-by: Josef Bacik Link: https://lore.kernel.org/r/20221018111240.22612-2-shikemeng@huawei.com Signed-off-by: Jens Axboe --- diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c index 571fa95aafe96..b24d7b788ba34 100644 --- a/block/blk-iolatency.c +++ b/block/blk-iolatency.c @@ -403,9 +403,6 @@ static void check_scale_change(struct iolatency_grp *iolat) u64 scale_lat; int direction = 0; - if (lat_to_blkg(iolat)->parent == NULL) - return; - parent = blkg_to_lat(lat_to_blkg(iolat)->parent); if (!parent) return;